Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump WDP revision to address memory leak #13943

Merged
merged 8 commits into from
Jul 20, 2022
Merged

Bump WDP revision to address memory leak #13943

merged 8 commits into from
Jul 20, 2022

Conversation

remusao
Copy link
Collaborator

@remusao remusao commented Jun 24, 2022 •
edited by atuchin-m
Loading

Resolves brave/brave-browser#23573
Fix in WDP brave/web-discovery-project#191

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@remusao remusao added the QA/No label Jun 24, 2022
@remusao remusao requested a review from a team as a code owner June 24, 2022 08:23
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jun 24, 2022
@atuchin-m atuchin-m force-pushed the bump-wdp-memory-leak-fix branch from c00cd5c to 3d1c52c Compare July 5, 2022 13:37
@atuchin-m
Copy link
Collaborator

There is a problem with webpack + linkedom.

21:06:33  WARNING in ./vendor/web-discovery-project/node_modules/star-wasm/star_wasm_bg.js 250:14-60
21:06:33  Critical dependency: the request of a dependency is an expression
21:06:33   @ ./vendor/web-discovery-project/node_modules/star-wasm/star_wasm.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/hpnv2/star.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/hpnv2/manager.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/hpnv2/background.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app/modules.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app/module.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/index.js
21:06:33   @ ./components/brave_extension/extension/brave_extension/background/webDiscoveryProject.ts
21:06:33   @ ./components/brave_extension/extension/brave_extension/background.ts
21:06:33  
21:06:33  WARNING in ./vendor/web-discovery-project/node_modules/linkedom/commonjs/canvas.cjs
21:06:33  Module not found: Error: Can't resolve 'canvas' in '/home/ubuntu/workspace/pr-brave-browser-bump-wdp-memory-leak-fix-linux/src/brave/vendor/web-discovery-project/node_modules/linkedom/commonjs'
21:06:33   @ ./vendor/web-discovery-project/node_modules/linkedom/commonjs/canvas.cjs
21:06:33   @ ./vendor/web-discovery-project/node_modules/linkedom/esm/html/canvas-element.js
21:06:33   @ ./vendor/web-discovery-project/node_modules/linkedom/esm/shared/html-classes.js
21:06:33   @ ./vendor/web-discovery-project/node_modules/linkedom/esm/index.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/web-discovery-project/html-helpers.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/web-discovery-project/web-discovery-project.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/web-discovery-project/background.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app/modules.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app/module.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/index.js
21:06:33   @ ./components/brave_extension/extension/brave_extension/background/webDiscoveryProject.ts
21:06:33   @ ./components/brave_extension/extension/brave_extension/background.ts
21:06:33  
21:06:33  WARNING in ./vendor/web-discovery-project/node_modules/linkedom/commonjs/perf_hooks.cjs
21:06:33  Module not found: Error: Can't resolve 'perf_hooks' in '/home/ubuntu/workspace/pr-brave-browser-bump-wdp-memory-leak-fix-linux/src/brave/vendor/web-discovery-project/node_modules/linkedom/commonjs'
21:06:33   @ ./vendor/web-discovery-project/node_modules/linkedom/commonjs/perf_hooks.cjs
21:06:33   @ ./vendor/web-discovery-project/node_modules/linkedom/esm/interface/document.js
21:06:33   @ ./vendor/web-discovery-project/node_modules/linkedom/esm/index.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/web-discovery-project/html-helpers.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/web-discovery-project/web-discovery-project.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/web-discovery-project/background.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app/modules.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app/module.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/core/app.js
21:06:33   @ ../out/Static/gen/brave/web-discovery-project/index.js
21:06:33   @ ./components/brave_extension/extension/brave_extension/background/webDiscoveryProject.ts
21:06:33   @ ./components/brave_extension/extension/brave_extension/background.ts

@atuchin-m
Copy link
Collaborator

atuchin-m commented Jul 5, 2022 •
edited
Loading

There is a problem with webpack + linkedom.

@petemill Could you please take a look, what we can do to support linkedom in WDP?

It seems that updating webpack to v5 could help, but I'm not sure can we do this or not:
cheeriojs/cheerio#2545 (comment)

@bsclifton bsclifton force-pushed the bump-wdp-memory-leak-fix branch from 3d1c52c to d5171d7 Compare July 8, 2022 21:58
@remusao remusao force-pushed the bump-wdp-memory-leak-fix branch 2 times, most recently from 313e9de to 52d1222 Compare July 15, 2022 07:05
@remusao remusao requested a review from a team as a code owner July 15, 2022 15:43
@remusao remusao force-pushed the bump-wdp-memory-leak-fix branch from 2c47b23 to e7a1cf8 Compare July 15, 2022 15:52
@remusao remusao requested review from goodov and atuchin-m July 16, 2022 07:02
@remusao remusao force-pushed the bump-wdp-memory-leak-fix branch from 9ec77b1 to acc9d2a Compare July 19, 2022 07:07
@remusao remusao requested a review from petemill July 19, 2022 07:07
@remusao remusao force-pushed the bump-wdp-memory-leak-fix branch from acc9d2a to 800a216 Compare July 19, 2022 08:12
@remusao remusao merged commit 57a4434 into master Jul 20, 2022
@remusao remusao deleted the bump-wdp-memory-leak-fix branch July 20, 2022 09:35
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atuchin-m atuchin-m atuchin-m approved these changes

@petemill petemill petemill approved these changes

@thypon thypon thypon approved these changes

@diracdeltas diracdeltas diracdeltas approved these changes

@goodov goodov Awaiting requested review from goodov

Assignees

@remusao remusao

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) QA/No
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.

Brave Extension high memory usage with WDP enabled
6 participants
@remusao @atuchin-m @diracdeltas @thypon @petemill @goodov